Fix grants/volumes test failure on azure-ucws#4880
Merged
Conversation
The METASTORE_NAME replacement (order 0) was running before the Azure-to-S3 URL normalization replacement (also order 0). On Azure, the storage URL is abfss:// not s3://, so METASTORE_NAME found no match. By the time the Azure URL was normalized to S3, the METASTORE_NAME pass had already completed. Fix by setting Order = -1 on the Azure URL normalization so it runs before METASTORE_NAME. Task: 001.md Co-authored-by: Isaac
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Co-authored-by: Isaac
Eligible reviewersCould not determine reviewers from git history. Based on CODEOWNERS, these people or teams could review: @andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum Suggestions based on git history of 1 changed files (0 scored). See CODEOWNERS for path-specific ownership rules. |
This reverts commit 7da3960.
Collaborator
|
Commit: 6a80188
20 interesting tests: 10 SKIP, 7 KNOWN, 3 flaky
Top 24 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Apr 1, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix
TestAccept/bundle/resources/grants/volumes/DATABRICKS_BUNDLE_ENGINE=directfailing on azure-ucws.The Azure-to-S3 URL normalization replacement in
volumes/test.tomland the[METASTORE_NAME]replacement in the roottest.tomlboth hadOrder = 0. Due to stable sort,METASTORE_NAMEran first — but on Azure the storage URL isabfss://, nots3://, so it found no match. By the time the Azure URL was normalized tos3://deco-uc-prod-isolated-aws-us-east-1/..., theMETASTORE_NAMEpass had already completed.Fix: set
Order = -1on the Azure URL normalization so it runs beforeMETASTORE_NAME.Tests